-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic OTLP Recordable #127
Implement basic OTLP Recordable #127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 71 71
Lines 1724 1724
=======================================
Hits 1612 1612
Misses 112 112 |
I signed my CLA. |
LGTM :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I only have one request about a missing CMake integration.
@pyohannes I've updated my code to address your comment, please let me know if there's anything else! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
@reyang This branch is ready to merge! |
Added and implemented
SetIds()
,SetStartTime()
andSetDuration()
for the OTLP Recordable. These functions should be enough to create minimal spans that can be sent to the OpenTelemetry Collector. Also added unit tests for the Recordable.